Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint example html #24478

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Lint example html #24478

merged 2 commits into from
Aug 12, 2022

Conversation

gero3
Copy link
Contributor

@gero3 gero3 commented Aug 9, 2022

Description

This PR adds the html examples to the linter. This also adds the cleaned up html files.

@Mugen87 Mugen87 added this to the r144 milestone Aug 10, 2022
@gero3
Copy link
Contributor Author

gero3 commented Aug 10, 2022

I've update the 3 examples by adding reasonable min and max distances

@mrdoob
Copy link
Owner

mrdoob commented Aug 10, 2022

Ops, looks like you added the builds by mistake.

@gero3 gero3 force-pushed the cleanup-example-html branch from 942642c to baec5e0 Compare August 10, 2022 13:57
@mrdoob mrdoob merged commit 1760846 into mrdoob:dev Aug 12, 2022
@mrdoob
Copy link
Owner

mrdoob commented Aug 12, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* cleanup example html

* add controls with min/max distance
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
* cleanup example html

* add controls with min/max distance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants