Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaders: remove unnecessary shader chunks #24475

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

WestLangley
Copy link
Collaborator

As suggested in #24469 (comment).

MMDToonShader, Basic, Lambert, and Phong do not support PMREM environment maps, so <cube_uv_reflection_fragment> can be removed.

@WestLangley
Copy link
Collaborator Author

@Mugen87 I wish there was a way to fail gracefully when PMREM is used in an unsupported way... 🤔

@mrdoob
Copy link
Owner

mrdoob commented Aug 10, 2022

Ops, we have a conflict here now.

@mrdoob mrdoob merged commit b398bc4 into mrdoob:dev Aug 11, 2022
@mrdoob
Copy link
Owner

mrdoob commented Aug 11, 2022

Thanks!

@WestLangley WestLangley deleted the dev_cube_uv_clean_up branch August 11, 2022 03:29
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants