Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLShaderCache: Avoid multiple map lookups. #24457

Merged
merged 2 commits into from
Aug 7, 2022

Conversation

jhurliman
Copy link
Contributor

Description

Partial fix for #24451 by reducing the number of Map lookups with large string keys made per frame.

This contribution is funded by Foxglove

@Mugen87 Mugen87 added this to the r144 milestone Aug 6, 2022
@Mugen87 Mugen87 changed the title Avoid multiple lookups in WebGLShaderCache _getShaderStage / _getShaderCacheForMaterial WebGLShaderCache: Avoid multiple map lookups. Aug 6, 2022
@Mugen87 Mugen87 merged commit ace307a into mrdoob:dev Aug 7, 2022
@mrdoob
Copy link
Owner

mrdoob commented Aug 9, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* Avoid multiple lookups in WebGLShaderCache _getShaderStage / _getShaderCacheForMaterial

* Update WebGLShaderCache.js

Co-authored-by: Michael Herzog <[email protected]>
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
* Avoid multiple lookups in WebGLShaderCache _getShaderStage / _getShaderCacheForMaterial

* Update WebGLShaderCache.js

Co-authored-by: Michael Herzog <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants