BufferGeometry: Remove merge(). #24454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkjohnson
approved these changes
Aug 9, 2022
|
Thanks! |
1 similar comment
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* BufferGeometry: Remove merge(). * Tests: Clean up.
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* BufferGeometry: Remove merge(). * Tests: Clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #24443
Description
Based on the discussion in #24443, this PR removes
BufferGeometry.merge(). Users are advised to merge their geometry data viaBufferGeometryUtilsinstead (for instancemergeBufferGeometries()).I have not restored the logic of
BufferGeometry.merge()as asetBufferAt()method since I think we should move the development towards more generic APIs and avoid user level code that performs direct array access (e.g.attribute.getX()vs.attribute.array) or requires knowledge about the data structure (interleaved vs non-interleaved data).