New WebGLNodeBuilder + Nodes: transmission #24453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is that output correct? |
Yees! hehe 😁 I put a three.js/examples/webgl_nodes_loader_gltf_transmission.html Lines 87 to 89 in f24997e |
Yeah, it looks like it's broken otherwise 😅 |
Ok, done!! |
LeviPesin
reviewed
Aug 9, 2022
| const checkerNode = checker( mul( add( uv(), vec2( 0, timerLocal( - .05 ) ) ), 7 ) ); | ||
|
|
||
| const nodeMaterial = NodeMaterial.fromMaterial( material ); | ||
| nodeMaterial.transmissionNode = float( 1 ); |
There was a problem hiding this comment.
I think we can write just 1 and 1.5 without any float().
There was a problem hiding this comment.
I think that no! This can't support primitive values here, just Node classes.
|
Still looks broken, in a different way now 😇 |
|
Updated :) |
|
Thanks! |
3 tasks
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* Cache CheckerNode if necessary * Nodes: Refactor, ior, specular, transmission nodes * update example * add transmission example * update transmission * update transmission (2) * update screenshot
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* Cache CheckerNode if necessary * Nodes: Refactor, ior, specular, transmission nodes * update example * add transmission example * update transmission * update transmission (2) * update screenshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #24385
Description
Part 4 / 4
I rewrote the Slots API and I added
transmission*Nodeandspecular*Node,iorNode.Now
WebGLNodeBuildercan detect the precedence of the slots and added the code/snippet always in the correct sequence.This contribution is funded by Google via Igalia