OutlinePass - Support InstancedMeshes #24440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Aug 3, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
|
I've encountered a bug in r144 after apply this patch, please see below image. After investigation, I found that the issue is introduced by this patch fix. @TobyGilbert Could you give any suggestion on how to fix it? |
|
I don't see any issues with webgl_postprocessing_outline. How can the example be modified so the above shader compilation error occurs? |
renderer.shadowMap.enabled = false; |
|
Ok yes seems USE_SHADOWMAP is not defined otherwise and worldPosition is not set. We could just move the instancing logic into the outline pass shader and not rely on the worldpos_vertex shader include. |
|
I've opened a PR to address this here #24681 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current mask material used in the outline pass does not support instanced meshes as it currently does not consider the instanced matrix, when computing its projected texture coordinates, for use when sampling the depth buffer. This small change utilises the worldpos_vertex chunk in order to do this.