FBXLoader: Handle invalid material indices. #24436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #24357.
Description
It seems there are exporters like the one from Cinema4D which might export FBX assets with negative material indices. I have found no official documentation about valid values of the FBX field
LayerElementMaterial.Materials.a. However, negative values are not supported inthree.js.The loader now reports a warning when negative material indices are detected and uses
0instead.Just want to note that an asset with missing material definitions is a model authoring error and should be fixed in a DCC tool.