Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Fix flow accordance of "roughness" used in transmission #24433

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 2, 2022

Description

Fix flow accordance of roughness used in transmission.

This contribution is funded by Google via Igalia

@WestLangley WestLangley added this to the r144 milestone Aug 2, 2022
@mrdoob
Copy link
Owner

mrdoob commented Aug 3, 2022

Ops... Could you fix the conflicts?

@sunag
Copy link
Collaborator Author

sunag commented Aug 3, 2022

Ops... Could you fix the conflicts?

Fixed!

@mrdoob mrdoob merged commit 3eaed95 into mrdoob:dev Aug 9, 2022
@mrdoob
Copy link
Owner

mrdoob commented Aug 9, 2022

Thanks!

@sunag sunag deleted the dev-transmission-cleanup branch August 10, 2022 01:17
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants