Remove long-deprecated code #24431
Merged
Remove long-deprecated code #24431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It had somehow broke something in 2b428c0... |
Mugen87
reviewed
Aug 2, 2022
Mugen87
reviewed
Aug 2, 2022
|
It seems the PR still breaks some examples... |
|
Should be fixed now. |
Mugen87
reviewed
Aug 3, 2022
Mugen87
approved these changes
Aug 4, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* Update SceneUtils.js * Update WebGLProgram.js * Update FontLoader.js * Update DRACOLoader.js * Update ObjectLoader.js * Delete custom-geometry.html * Delete custom-geometry.html * Delete custom-geometry.html * Delete custom-geometry.html * Delete custom-geometry.html * Delete custom-geometry.html * Update TransformControls.js * Update GLTFLoader.js * Update OutlineEffect.js * Update VRButton.js * Update HDRCubeTextureLoader.js * Update ShaderMaterial.js * Update TrackballControls.js * Update OrbitControls.js * Update ColorConverter.js * Update InstancedBufferAttribute.js * Update ParametricGeometry.js * Update CubeCamera.js * Update PointerLockControls.js * Update Projector.js * Update DRACOExporter.js * Update FirstPersonControls.js * Update FlyControls.js * Update PLYExporter.js * Update Quaternion.js * Update GLTFExporter.js * Update Uniform.js * Un-deprecate `decodeDracoFile` * Update ColladaExporter.js * Update GLTFExporter.js * Update OBJExporter.js * Update STLExporter.js * Revert loop change * Update GLTFLoader.js
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* Update SceneUtils.js * Update WebGLProgram.js * Update FontLoader.js * Update DRACOLoader.js * Update ObjectLoader.js * Delete custom-geometry.html * Delete custom-geometry.html * Delete custom-geometry.html * Delete custom-geometry.html * Delete custom-geometry.html * Delete custom-geometry.html * Update TransformControls.js * Update GLTFLoader.js * Update OutlineEffect.js * Update VRButton.js * Update HDRCubeTextureLoader.js * Update ShaderMaterial.js * Update TrackballControls.js * Update OrbitControls.js * Update ColorConverter.js * Update InstancedBufferAttribute.js * Update ParametricGeometry.js * Update CubeCamera.js * Update PointerLockControls.js * Update Projector.js * Update DRACOExporter.js * Update FirstPersonControls.js * Update FlyControls.js * Update PLYExporter.js * Update Quaternion.js * Update GLTFExporter.js * Update Uniform.js * Un-deprecate `decodeDracoFile` * Update ColladaExporter.js * Update GLTFExporter.js * Update OBJExporter.js * Update STLExporter.js * Revert loop change * Update GLTFLoader.js
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
Remove some long-deprecated code and checks (hopefully all of them, although unsure).