Toon shading add antialiasing #24406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have any before / after pictures? |
|
@gkjohnson Updated the post with a screenshot of our game before/after. The example provided is using the exact same logic: // before
vec3 res = ( coord.x < 0.7 ) ? backColor : vec3( 1.0 );
// after
vec3 res = mix( backColor, vec3( 1.0 ), smoothstep( 0.7 - fw.x, 0.7 + fw.x, coord.x)); |
gkjohnson
reviewed
Jul 30, 2022
| @@ -18,7 +18,8 @@ vec3 getGradientIrradiance( vec3 normal, vec3 lightDirection ) { | |||
|
|
|||
| #else | |||
|
|
|||
| return ( coord.x < 0.7 ) ? vec3( 0.7 ) : vec3( 1.0 ); | |||
| vec2 fw = fwidth( coord ); | |||
| return mix( vec3( 0.7 ), vec3( 1. ), smoothstep( 0.7 - fw.x, 0.7 + fw.x, coord.x)); | |||
There was a problem hiding this comment.
Have you considered halving the fw when using it as a step in the smoothstep function? As it is the step will happen over two pixels which will result in a less crisp edge than it could be:
return mix( vec3( 0.7 ), vec3( 1.0 ), smoothstep( 0.7 - fw.x * 0.5, 0.7 + fw.x * 0.5, coord.x ) );Also nit: can we use 1.0 instead of 1. for consistency and make sure we have consistent spaces inside the parens.
There was a problem hiding this comment.
Indeed! Updated the PR with the changes.
gkjohnson
approved these changes
Jul 30, 2022
There was a problem hiding this comment.
Code looks good to me! I trust @RenaudRohlinger has tested it.
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* Toon shading add antialiasing * Update gradientmap_pars_fragment.glsl.js * Update gradientmap_pars_fragment.glsl.js * Update gradientmap_pars_fragment.glsl.js Co-authored-by: Michael Herzog <[email protected]>
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* Toon shading add antialiasing * Update gradientmap_pars_fragment.glsl.js * Update gradientmap_pars_fragment.glsl.js * Update gradientmap_pars_fragment.glsl.js Co-authored-by: Michael Herzog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds antialiasing to the getGradientIrradiance function.
Before:
.
After:
Edit: Added screenshot example.