Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaders: Remove workaround for Adreno bug #24390

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

WestLangley
Copy link
Collaborator

@WestLangley WestLangley commented Jul 27, 2022

Related issue: #9988

Perhaps it's OK to remove this workaround circa 2016.

@WestLangley WestLangley added this to the r143 milestone Jul 27, 2022
@WestLangley
Copy link
Collaborator Author

/ping @sunag If this is merged, similar changes can be made in Node.

@sunag
Copy link
Collaborator

sunag commented Jul 27, 2022

/ping @sunag If this is merged, similar changes can be made in Node.

Yes... Thanks for let me know.

Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workaround was added for Adreno 300 series and the respective Snapdragon SoCs are not used for new phones since a couple of years now. I think we can risk to remove it.

@mrdoob mrdoob merged commit d9a8da2 into mrdoob:dev Jul 28, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jul 28, 2022

Thanks!

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 8, 2022

@WestLangley It seems we can also refactor the following now?

// Workaround for Adreno GPUs not able to do dFdx( vViewPosition )
vec3 fdx = vec3( dFdx( vViewPosition.x ), dFdx( vViewPosition.y ), dFdx( vViewPosition.z ) );
vec3 fdy = vec3( dFdy( vViewPosition.x ), dFdy( vViewPosition.y ), dFdy( vViewPosition.z ) );
vec3 normal = normalize( cross( fdx, fdy ) );

@WestLangley
Copy link
Collaborator Author

@Mugen87 Good point! 👍

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants