Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Introduce WebGPUUtils. #24379

Merged
merged 2 commits into from
Jul 22, 2022
Merged

WebGPURenderer: Introduce WebGPUUtils. #24379

merged 2 commits into from
Jul 22, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 21, 2022

Related issue: #24373 (comment)

Description

Moving some methods of WebGPURenderer to a new internal module to keep the public interface clean.

@Mugen87 Mugen87 requested a review from sunag July 21, 2022 15:45
@Mugen87 Mugen87 added this to the r143 milestone Jul 21, 2022
@sunag
Copy link
Collaborator

sunag commented Jul 21, 2022

@Mugen87 Wouldn't it be better to move the functions of WebGPUConfig to WebGPURenderPipelines?
The first impression I have when reading WebGPUConfig is something related to the user setting.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 21, 2022

I'd like to put methods to a new module that can be used everywhere in the renderer. WebGPURenderPipelines is too specific for this task. Besides, WebGPURenderPipeline should not have a reference to WebGPURenderPipelines.

Maybe we can rename WebGPUConfig to something different?

@sunag
Copy link
Collaborator

sunag commented Jul 21, 2022

Maybe we can rename WebGPUConfig to something different?

Maybe WebGPUPipelineUtils?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 21, 2022

Would WebGPUUtils be good, too? I'd favor a more generic name so we can easier use the module for other use cases.

@sunag
Copy link
Collaborator

sunag commented Jul 22, 2022

Would WebGPUUtils be good, too? I'd favor a more generic name so we can easier use the module for other use cases.

WebGPUUtils sounds good for me!!

@Mugen87 Mugen87 changed the title WebGPURenderer: Introduce WebGPUConfig. WebGPURenderer: Introduce WebGPUUtils. Jul 22, 2022
@Mugen87 Mugen87 merged commit 085222f into mrdoob:dev Jul 22, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jul 27, 2022

Thanks!

@joshuaellis joshuaellis mentioned this pull request Jul 28, 2022
4 tasks
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* WebGPURenderer: Introduce WebGPUConfig.

* Rename WebGPUConfig to WebGPUUtils
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
* WebGPURenderer: Introduce WebGPUConfig.

* Rename WebGPUConfig to WebGPUUtils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants