Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Clean up. #24367

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Examples: Clean up. #24367

merged 1 commit into from
Jul 19, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 19, 2022

Related issue: #24311

Description

Minor clean up and simplifications.

@Mugen87 Mugen87 added this to the r143 milestone Jul 19, 2022
@Mugen87 Mugen87 merged commit baa9338 into mrdoob:dev Jul 19, 2022
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 19, 2022

@WestLangley No HDR environment map in the repo looks as good as textures/cube/lake/. IMO, venice_sunset_1k.hdr produces the best result so far but the projection results in some "flat" pedestrians which looks odd.

I tend to leave the current LDR env map in place. Feel free to file a PR if you think a different env map looks better.

@mrdoob
Copy link
Owner

mrdoob commented Jul 20, 2022

I was hoping quarry_01_1k.hdr would be a pretty good fit?

@mrdoob
Copy link
Owner

mrdoob commented Jul 20, 2022

Or maybe this one?
https://polyhaven.com/a/blouberg_sunrise_2

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 20, 2022

blouberg_sunrise_2 looks awesome! The transition between the ground and the back looks very subtle with this one. I'll file a PR.

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants