Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USDZExporter: Fix import. #24366

Merged
merged 1 commit into from
Jul 19, 2022
Merged

USDZExporter: Fix import. #24366

merged 1 commit into from
Jul 19, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 19, 2022

Related issue: #24214 (comment)

Description

This PR properly imports DoubleSide from three instead of using the THREE namespace.

@Mugen87 Mugen87 merged commit fa46002 into mrdoob:dev Jul 19, 2022
@Mugen87 Mugen87 added this to the r143 milestone Jul 19, 2022
@Mugen87 Mugen87 mentioned this pull request Jul 19, 2022
Merged
@elalish elalish mentioned this pull request Jul 19, 2022
Merged
@mrdoob
Copy link
Owner

mrdoob commented Jul 20, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
@Mugen87 @abernier
USDZExporter: Fix import. (mrdoob#24366)
8290bf9
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
@Mugen87 @snagy
USDZExporter: Fix import. (mrdoob#24366)
9b96790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r143
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @mrdoob