Deprecate legacy BufferGeometry nomenclature for built-in geometries #24352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the right approach would be to do this in |
|
We only put deprecated methods or properties into non-deprecated classes. Legacy classes should go into
Looking good. |
WestLangley
force-pushed
the
dev-buffer_geometries
branch
from
285ade7 to
9abfc1d
Compare
Mugen87
approved these changes
Jul 17, 2022
|
Let's merge before too many conflicts ensue. New build required. |
|
What if we just removed these aliases? 🤔 |
@Mugen87 What do you prefer? |
|
I've thought the policy was to first deprecated things and then make the removal after 10 releases. I personally would prefer to keep doing this especially in this case since I frequently see the usage of |
|
@Mugen87 Sounds good! |
|
Thanks! |
This was referenced Aug 17, 2022
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
…rdoob#24352) * Deprecate legacy nomenclature * Update revision number
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
…rdoob#24352) * Deprecate legacy nomenclature * Update revision number
wiledal
pushed a commit
to pmndrs/react-three-rapier
that referenced
this pull request
Oct 4, 2022
usefulthink
added a commit
to usefulthink/js-three
that referenced
this pull request
Feb 1, 2023
Last year, [three.js deprecated the `XxxBufferGeometry` classes](mrdoob/three.js#24352), this change adjust example code to no longer use them and use the new versions instead.
amuramoto
pushed a commit
to googlemaps/js-three
that referenced
this pull request
Feb 2, 2023
Last year, [three.js deprecated the `XxxBufferGeometry` classes](mrdoob/three.js#24352), this change adjust example code to no longer use them and use the new versions instead.
github-actions bot
pushed a commit
to googlemaps/js-three
that referenced
this pull request
Feb 2, 2023
Last year, [three.js deprecated the `XxxBufferGeometry` classes](mrdoob/three.js#24352), this change adjust example code to no longer use them and use the new versions instead. e488ed2
github-actions bot
pushed a commit
to ehtick/js-three
that referenced
this pull request
Feb 2, 2023
Last year, [three.js deprecated the `XxxBufferGeometry` classes](mrdoob/three.js#24352), this change adjust example code to no longer use them and use the new versions instead. e488ed2
kui
added a commit
to kui/7dtd-map
that referenced
this pull request
Jun 11, 2023
Mercury21th000
pushed a commit
to Mercury21th000/react-three-rapier
that referenced
this pull request
Nov 17, 2024
naotokato111
added a commit
to naotokato111/react-three-rapier
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #24349 (comment).
Does this look like the right approach? If so, I'll add the remaining geometries.