Shaders: Renamed linearToRelativeLuminance() function #24347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
approved these changes
Jul 13, 2022
Mugen87
approved these changes
Jul 13, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
|
Sorry for the late response in the already merged PR. If I'm right, this function doesn't seem to be used in the core. Do we really want to keep this function in the core? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the
linearToRelativeLuminance()function.We are not computing "relative luminance" here since we are are not normalizing the input. The input is unbounded.
Furthermore, the formula is correct only if the RGB-valued input is in a linear color space with sRGB primaries and D65 white point. If the working color space were to change, then different weights would be required.
Consequently, I renamed the method to
luminance(), and added an inline comment explaining the assumptions.Alternatively, the function could be named something more precise, such as
linearSRGBtoLuminance(), but personally, I think that is overkill for now. My expectation is the three.js working color space is not going to change any time soon -- certainly not until wide-gamut monitors are commonplace -- so the simpler method name seems acceptable to me.Other opinions welcome.
/ping @donmccurdy