Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree-shaking: AnimationUtils #24337

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Conversation

pschroen
Copy link
Contributor

Related issue: #24199

Troubleshooting the remaining side-effects in r142 with webpack, converted AnimationUtils to a plain functions pattern to allow for tree-shaking, linted and tested with the keyframes example.

@mrdoob mrdoob added this to the r143 milestone Jul 12, 2022
@mrdoob mrdoob merged commit 88ee281 into mrdoob:dev Jul 12, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jul 12, 2022

Thanks!

@joshuaellis joshuaellis mentioned this pull request Jul 18, 2022
4 tasks
@pschroen pschroen deleted the tree-shaking-animationutils branch July 22, 2022 12:44
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants