Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LatheGeometry: Fix normals of default shape. #24308

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 4, 2022

Related issue: -

Description

The point sequence of the default shape was defined in the wrong direction which produced inverted normals.

@Mugen87 Mugen87 changed the title LathGeometry: Fix normals of default shape. LatheGeometry: Fix normals of default shape. Jul 4, 2022
@Mugen87 Mugen87 merged commit 4065706 into mrdoob:dev Jul 4, 2022
@Mugen87 Mugen87 added this to the r143 milestone Jul 4, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jul 4, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants