FileLoader: Add response to error object. #24296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I include my company in the description? They are paying me lol |
|
Do you mind rebasing your PR? The PR diff shows many unrelated changes.
Do whatever you think it's best. The section |
Mugen87
changed the title
Mugen87
reviewed
Jul 1, 2022
Yeah I can do that. Those changes came from the linter. I'll remove them. |
Mugen87
reviewed
Jul 2, 2022
Mugen87
approved these changes
Jul 8, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* Surface fetch Response object in Error when non 200 HTTP status is received * Remove HttpError from export
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* Surface fetch Response object in Error when non 200 HTTP status is received * Remove HttpError from export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #24295
Description
If a non-200 HTTP status is received in the FileLoader, I would like to have a safer way to check that then checking the error message text.
I added a custom HttpError type that adds an extra property to include the fetch Response object in the Error object. This seems like the best way to let devs do as they wish when this happens.
This is backwards compatible, and I tested by linking my local branch of three to my project
Also I ran lint-fix on everything hence the changes in the extra files.