Fix small bug in crossFade animation example #24287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems it still happens if you open the URL and directly click on |
|
Fixed, good that you have spoted it. |
|
@mudroljub I've moved the check a bit so |
Mugen87
approved these changes
Jun 30, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* fix small bug * fix tabs instead of spaces * fix idle action * Update webgl_animation_skinning_additive_blending.html Co-authored-by: Michael Herzog <[email protected]>
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* fix small bug * fix tabs instead of spaces * fix idle action * Update webgl_animation_skinning_additive_blending.html Co-authored-by: Michael Herzog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #XXXX
Description
I found a small bug in crossFade animation example on threejs.org website:
https://threejs.org/examples/#webgl_animation_skinning_additive_blending
BUG: When you click again on the active animation (for example run or walk), the character first put hands in T position, then continue with the same animation.
My pull request solves it and the animation is smooth now.