Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Remove deprecated code. #24286

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Core: Remove deprecated code. #24286

merged 1 commit into from
Jun 30, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 29, 2022

Related issue: -

Description

According to the project's policy, legacy code is removed after ten releases. The PR removes code which has been deprecated for quite a while now:

@LeviPesin
Copy link
Contributor

Can we also remove utils/exporters/blender? It was removed in r92 and just a notice remains there.

@mrdoob mrdoob added this to the r143 milestone Jun 30, 2022
@mrdoob mrdoob merged commit 637067e into mrdoob:dev Jun 30, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jun 30, 2022

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Jun 30, 2022

@LeviPesin

Can we also remove utils/exporters/blender? It was removed in r92 and just a notice remains there.

I think so yes!

@LeviPesin
Copy link
Contributor

LeviPesin commented Jul 4, 2022

I think we should also remove some long-deprecated checks like

console.error( 'THREE.Matrix4: the constructor no longer reads arguments. use .set() instead.' );
and
console.warn( 'THREE.Matrix4: .multiply() now only accepts one argument. Use .multiplyMatrices( a, b ) instead.' );
.

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants