Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force node matrixAutoUpdate to true in the gltf animation loader #24284

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

snagy
Copy link
Contributor

@snagy snagy commented Jun 28, 2022

Description

The glTF loader was setting matrixAutoUpdate to 'true' on any node that's used as part of an animation. This ignores the object3d DefaultMatrixAutoUpdate setting, and causes problems if folks are trying to manage their updates themselves. Removed the line that sets the autoupdate, so instead animation nodes will follow the default setting.

This code doesn't exist in any other loaders.

All the animation samples still work. Most projects won't be affected because the default auto update setting is 'true'.

This contribution is funded by Meta

@donmccurdy
Copy link
Collaborator

/cc @takahirox do you recall why this is here?

I don't remember, so fine with me to remove if the skinning examples are still working without it.

@takahirox
Copy link
Collaborator

No idea why we did it... And coincidentally I was going to suggest to remove the line, too, because Mozilla Hubs manages matrices updates by our selves.

@Mugen87 Mugen87 added this to the r143 milestone Jun 30, 2022
@mrdoob mrdoob merged commit 4fb1756 into mrdoob:dev Jul 7, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jul 7, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants