PLYLoader: Fix for linesplitting on universal newlines #24264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwegash
force-pushed
the
fix-ply-newlines
branch
from
b4ed33d to
86ace31
Compare
|
Normally, carriage returns should only be used in the header however not every exporter follows this convention since the spec is not specific enough. That's indeed unfortunate. It's probably best to accept any line ending style in the loader. |
Mugen87
approved these changes
Jun 23, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
Co-authored-by: George Ash <[email protected]>
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
Co-authored-by: George Ash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
\r\nor\nbut not\r.\rThis PR fixes the problem by allowing line splitting on
\rcharacters too, so the PLYLoader should now support universal newlines.