-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLTFLoader: add getDependency( type, index ) implementation #24252
Conversation
No conlusion yet but let me share what I'm worried about so far. (It would be better than no response for long.) I'm thinking whether it is good to let Perhaps the root issue may be the current plugin system doesn't expect that an extension has dependency with other extensions.... |
Yes, with KHR_animation_pointer an extension certainly has dependencies to other extensions. I think I'm happy to change |
I think it might be better to make the glTF plugins expose an optional For example in
or
And the default loader doesn't need to know anything about |
Like this?
|
Yeah, exactly 👍 |
Maybe that sounds good. Nit:
|
b081e45
to
b309ca2
Compare
I rebased this on dev and implemented the suggestions from here – let me know if that works, thanks @takahirox! Regarding the |
Description
@takahirox requested that the
getDependency('light')
implementation should be a separate PR, so here it is.This is in preparation for supporting the KHR_animation_pointer glTF extension in three.js.
This PR adds a new way for extensions to implement
getDependency( type, index )
for custom types; targets for implementation are right nowlight
andaudio
.Related: