WebGLRenderer: call setTextureCube and setTexture3D on initTexture #24245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
action-script
force-pushed
the
expose-setTexture3D
branch
2 times, most recently
from
8e4fb11 to
c66c1df
Compare
Mugen87
reviewed
Jun 18, 2022
Mugen87
reviewed
Jun 18, 2022
action-script
force-pushed
the
expose-setTexture3D
branch
from
c66c1df to
c6aaaf9
Compare
Clean up.
Mugen87
approved these changes
Jun 20, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
…rdoob#24245) * WebGLRenderer: call setTextureCube and setTexture3D on initTexture * Update WebGLRenderer.js Clean up. Co-authored-by: Michael Herzog <[email protected]>
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
…rdoob#24245) * WebGLRenderer: call setTextureCube and setTexture3D on initTexture * Update WebGLRenderer.js Clean up. Co-authored-by: Michael Herzog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose setTextureCube and setTexture3D functions at the WebGLRenderer initTexture.
So CubeTextures and Data3DTextures can be loaded on memory at the setup.
Same logic, usability and functionality as the former initTexture but allowing environment maps to also be properly pre-loaded.