Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArcballControls: Use dispose() in makeGizmos(). #24241

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 16, 2022

Related issue: https://discourse.threejs.org/t/arcballcontrols-gizmos-leaking-geometries/39281

Description

A user (@Vlad-Apostolov) in the forum noticed that makeGizmos() does not properly remove objects from the scene.

@mrdoob mrdoob added this to the r142 milestone Jun 17, 2022
@mrdoob mrdoob merged commit 533cf80 into mrdoob:dev Jun 17, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jun 17, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants