Disable sRGBA format for WebXR #24222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrdoob Can we merge this? The current behavior will break a future build of the Quest browser. |
|
also @Mugen87 |
Mugen87
approved these changes
Jun 11, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebXR manager is creating an sRGB swapchain when using layers.
This is different from 2D or the regular WebXR workflows.
There were bugs in the Quest browser where it didn't handle sRGB gamma correction properly. However, we fixed that bug and now we see that three.js has the wrong colors when the experience is using sRGB.
With latest browser, you will see that gamma is applied twice, likely once by three and once when rgb colors are rendered into the srgb swapchain.
This contribution is funded by Meta