WebGPURenderer: Support to .backgroundNode
#24213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ping @mrdoob |
|
Looking good! |
|
Hmm... Shouldn't the helmet go white when the brightness is set to 1 too?
|
|
Hmm... I will remove the |
LeviPesin
reviewed
Jun 9, 2022
| @@ -41,6 +46,38 @@ class WebGPUBackground { | |||
| _clearAlpha = 1; | |||
| forceClear = true; | |||
|
|
|||
| } else if ( background.isNode === true ) { | |||
There was a problem hiding this comment.
Can we actually create BackgroundNode, which will do this (at least creating a mesh and aligning it to the camera) by itself? I think it will allow to more easily implement in the future the Background suggestion.
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* beautify matrix columns * add support to .onBeforeRender() * add support to .backgroundNode * add .backgroundNode to examples * cleanup * cleanup * remove brightness, rename contrast to intensity * fix get empty image[0]
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* beautify matrix columns * add support to .onBeforeRender() * add support to .backgroundNode * add .backgroundNode to examples * cleanup * cleanup * remove brightness, rename contrast to intensity * fix get empty image[0]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live
https://raw.githack.com/sunag/three.js/dev-backgroundNode/examples/webgpu_cubemap_adjustments.html
webgpu_cubemap_adjustments.mp4
WebGPURenderer
WebGPU Examples
This contribution is funded by Google via Igalia