Fix a typo in multiple places #24195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove build files from this PR. |
|
The typo was also in the build files. Why remove them? |
|
Because they are auto-built from the source files. |
|
How would I remove the files from the PR? I changed the typos all in one commit, so I don't know how I could remove the files without deleting the pull request and starting over. |
|
Push the second commit to the branch. |
|
What second commit? I only made one commit, and it changed the typo in all 5 places. |
|
Make a new, second commit restoring the build files and just push it to the branch. |
Since the build files are auto-generated from the source, the typo should only have fixed it in the src folder. This commit fixes that
|
Sorry for the trouble. I am basically github illiterate. I really only use it for storing code, so I don't really know how it works past git command line stuff for pushing and pulling. |
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* Fix a typo in multiple places * Undo typo fix in build files Since the build files are auto-generated from the source, the typo should only have fixed it in the src folder. This commit fixes that Co-authored-by: Carl Lee Landskron <[email protected]>
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* Fix a typo in multiple places * Undo typo fix in build files Since the build files are auto-generated from the source, the typo should only have fixed it in the src folder. This commit fixes that Co-authored-by: Carl Lee Landskron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Was not put into a Github Issue. Issue is on three.js discourse
Description
There was a typo in every single three.js file, and the three.js source file. The typo was where in a few places, instead of "interleaved" the files said "interlaved." This pull request will fix that.