Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve OBJLoader #24175

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Improve OBJLoader #24175

merged 1 commit into from
Jun 3, 2022

Conversation

Degubi
Copy link
Contributor

@Degubi Degubi commented Jun 2, 2022

Description

  • Cache face & vertex data splitter regex, no need to recreate it every time we split a line.
  • Replace deprecated trimLeft calls with trimStart. VsCode was marking trimLeft as deprecated, replaced it with the recommended alternative: trimStart.
  • Replace some let declarations with const

@Degubi
Improve OBJLoader
5699789 
- Cache data splitter regex
- Replace deprecated trimLeft calls with trimStart
- Replace some let declarations with const
@mrdoob mrdoob added this to the r142 milestone Jun 3, 2022
@mrdoob mrdoob merged commit cba85c5 into mrdoob:dev Jun 3, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jun 3, 2022

Thanks!

@Degubi Degubi deleted the improve_obj_loader branch June 3, 2022 07:59
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
@Degubi @abernier
Improve OBJLoader (mrdoob#24175)
38ac444 
- Cache data splitter regex
- Replace deprecated trimLeft calls with trimStart
- Replace some let declarations with const
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
@Degubi @snagy
Improve OBJLoader (mrdoob#24175)
c143a51 
- Cache data splitter regex
- Replace deprecated trimLeft calls with trimStart
- Replace some let declarations with const
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r142
Development

Successfully merging this pull request may close these issues.
3 participants
@Degubi @mrdoob @Mugen87