Fix pointer duplication issue in WebXR Hand Examples #24142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
mrdoob
added a commit
that referenced
this pull request
May 30, 2022
* Fix pointer duplication issue in WebXR Hand Examples * Update OculusHandPointerModel.js Co-authored-by: mrdoob <[email protected]>
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* Fix pointer duplication issue in WebXR Hand Examples * Update OculusHandPointerModel.js Co-authored-by: mrdoob <[email protected]>
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* Fix pointer duplication issue in WebXR Hand Examples * Update OculusHandPointerModel.js Co-authored-by: mrdoob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #24055
Description
The WebXR hand examples were made with the assumption that the hands
connectedevent would only fire once, which is the current behavior in Oculus Quest, but not in Hololens (which send connected / disconnected events as hands enter and leave the view). This changes the pointer creation logic in the hands examples so that it'd only create the pointer on theconnectedevent if no pointer has already been created.Note that I do not own a Hololens device so I have not personally tested this to make sure that the behavior is correct on Hololens. An alternative to this would be to destroy the pointers on
disconnectedevents, and recreate it onconnected.