WebGLMultipleRenderTargets: Example fix iOS with MSAA #24141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is another issue only on iOS, some texture types will break in certain cases. I don't have an explanation of the why, I think it's just a bug. Also, there was an issue with Safari which was fixed in the latest version (15.5) where it was required to clear the canvas before rendering the scene. I only added comments since this issue has been patched, should we add it anyway?
Comment on lines
248
to
254
| // safari prior 15.5 needs the renderer to be cleared() | ||
| // if ( parameters.samples > 0 ) { | ||
|
|
||
| // renderer.clear(); | ||
|
|
||
| // } | ||
|
|
There was a problem hiding this comment.
This also affected scenes that used antialias on the renderer, with gl.clear() being a workaround that accepted any combination of bits -- even simply zero.
Since being patched, I think we can direct users to keep their browsers up-to-date rather than employ these workarounds. iOS is a bit too unstable for comfort.
|
I would prefer to keep code like this out of the examples. They don't have to demonstrate how to achieve a library feature with older/buggy browsers. |
|
Alright! Just fix the iOS issue by removing the unnecessary float texture format 👍 |
Mugen87
approved these changes
May 28, 2022
mrdoob
pushed a commit
that referenced
this pull request
May 30, 2022
* WebGLMultipleRenderTargets: Example fix iOS with MSAA There is another issue only on iOS, some texture types will break in certain cases. I don't have an explanation of the why, I think it's just a bug. Also, there was an issue with Safari which was fixed in the latest version (15.5) where it was required to clear the canvas before rendering the scene. I only added comments since this issue has been patched, should we add it anyway? * Update webgl2_multiple_rendertargets.html
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* WebGLMultipleRenderTargets: Example fix iOS with MSAA There is another issue only on iOS, some texture types will break in certain cases. I don't have an explanation of the why, I think it's just a bug. Also, there was an issue with Safari which was fixed in the latest version (15.5) where it was required to clear the canvas before rendering the scene. I only added comments since this issue has been patched, should we add it anyway? * Update webgl2_multiple_rendertargets.html
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* WebGLMultipleRenderTargets: Example fix iOS with MSAA There is another issue only on iOS, some texture types will break in certain cases. I don't have an explanation of the why, I think it's just a bug. Also, there was an issue with Safari which was fixed in the latest version (15.5) where it was required to clear the canvas before rendering the scene. I only added comments since this issue has been patched, should we add it anyway? * Update webgl2_multiple_rendertargets.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is another issue only on iOS, some texture types will break in certain cases. I don't have an explanation of the why, I think it's just a bug.
Also, there was an issue with Safari which was fixed in the latest version (15.5) where it was required to clear the canvas before rendering the scene. I only added comments since this issue has been patched, should we add it anyway?