Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add note regarding .map alpha channel transparency #24134

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

ggPeti
Copy link
Contributor

@ggPeti ggPeti commented May 26, 2022

Description

We were searching for a while scratching our heads why alpha channel wasn't applied. This information would have helped us find the solution earlier.

@ggPeti
Copy link
Contributor Author

ggPeti commented May 29, 2022

I've updated the other pages according to @donmccurdy's and @Mugen87's suggestions. The Chinese translations are done with DeepL + me taking snippets from existing documentation. @puxiao I see you've been involved with Chinese documentation recently, can you please review?

@puxiao
Copy link
Contributor

puxiao commented May 30, 2022

@ggPeti
I think "The color map" should be translated as "颜色贴图", not "色图".

emmm....

"色图" in Chinese usually alludes to "erotic pictures".

color_map

@ggPeti
Copy link
Contributor Author

ggPeti commented May 30, 2022

lol

@mrdoob mrdoob changed the title Add note regarding .map alpha channel transparency Docs: Add note regarding .map alpha channel transparency Jun 7, 2022
@mrdoob mrdoob added this to the r142 milestone Jun 7, 2022
@mrdoob mrdoob merged commit 1387439 into mrdoob:dev Jun 7, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jun 7, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* Add note regarding .map alpha channel transparency

* update documentation with suggestions

* zh docs: replace phrase
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
* Add note regarding .map alpha channel transparency

* update documentation with suggestions

* zh docs: replace phrase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants