-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDSLoader: Remove FourCC
header check.
#24124
Conversation
FourCC code is missing iff the file contains uncompressed texture and the DDSLoader seems to support uncompressed textures.
I think reporting a controlled error is better than producing a real exception. Hence, I would keep the check. It's like when |
But it does not produce an exception. |
DDSLoader supports uncompressed textures: https://github.com/mrdoob/three.js/blob/dev/examples/jsm/loaders/DDSLoader.js#L190-L198 |
Ah... So the problem was that the check was actually not working as intended, neither it was needed? |
Yes. Maybe the support for uncompressed textures was added after the check? |
It seems that it was already like this in the first implementation of DDSLoader but it was not in the webgl-texture-utils implementation (it did not support uncompressed textures and had broken check). |
Sounds good 👍 |
Thanks! |
FourCC code is missing iff the file contains uncompressed texture and the DDSLoader seems to support uncompressed textures.
Related issue: #24121
Description
FourCC code is missing iff the file contains uncompressed texture and the DDSLoader seems to support uncompressed textures.