-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object3D: Honor recursive
parameter of copy()
in subclasses.
#24119
Object3D: Honor recursive
parameter of copy()
in subclasses.
#24119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good to make this change in order for consistency reasons. Please honor all remaining classes like InstancedMesh
, Points
or Sprite
.
Ah yes, I missed those. Done now. |
Thanks! |
recursive
parameter in copy()
of subclasses.
recursive
parameter in copy()
of subclasses.recursive
parameter of copy()
in subclasses.
The changes in the Object3D is causing error when loading animated gltf "THREE.Object3D.add: object not an instance of THREE.Object3D. undefined" |
Can you please explain in more detail how this change produce the mentioned error? The examples load animated glTF assets without issues e.g. https://threejs.org/examples/webgl_animation_skinning_blending |
I trace the error at the car engine sound, I think the car engine is obsolete https://github.com/Antonio-R1/engine-sound-generator |
release 141 feels fast and lighter, |
The above project relies on |
There was nothing wrong with the car engine sound https://github.com/Antonio-R1/engine-sound-generator works perfectly with threejs release 141, the error was occurring from my code bug when I load the gltf |
…t3D (mrdoob#24119) * honor recursive argument in copy method of classes derived from Object3D * add recursive argument to copy method of classes inheriting from Object3D
Description
I've had a situation where I would need to clone a Spotlight or PointLight which had children, but without wanting those children. It did not seem possible as the
copy
method did not pass therecursive
argument to the inheritedObject3D.copy
method.So I've added the
recursive
argument to thecopy
method of a few classes.Unless there is a reason of not allowing to pass the recursive argument is intentional, which I may have missed?