Node: add .construct() and some architectural changes #24110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
ShaderNode
withanalyze()
to optimization brought some other challenges. The current approach useShaderNode
directly in the.generate()
stage, ignoring the previous stageanalyze()
. It caused some bugs and bad optimization for non-inline codes. To solve this, I worked on a process to.construct()
the shader struct before.analyze()
and.generate()
.I'm working to make the same thing to
ComputeNode
."shader nodes" in this case it would be the nodes created at the time of the renderer for calculating the lighting.
NormalMapNode
added on.generate()
stage-> no cache has created
NormalMapNode
added on.construct()
stage-> cache working done
This contribution is funded by Google via Igalia