Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Add PCDLoader. #24106

Merged
merged 1 commit into from
May 23, 2022
Merged

Editor: Add PCDLoader. #24106

merged 1 commit into from
May 23, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 23, 2022

Related issue: -

Description

The editor can now load PCD assets which makes it easier to debug PCD files. The PR also ensures the number of vertices is now correctly displayed for point clouds in the info section.

To make this change work, it was necessary to remove the file name extraction from PCDLoader.parse() which requires an URL. Since this kind of logic is unusual for a loader, it's better to remove it in any event.

@mrdoob mrdoob added this to the r141 milestone May 23, 2022
@mrdoob mrdoob merged commit eab2a29 into mrdoob:dev May 23, 2022
@mrdoob
Copy link
Owner

mrdoob commented May 23, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants