Docs: Update "How to run things locally" #24097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current wording offers two options and suggests we'll explain both, but then only explains the second. As discussed in #15334 we should not encourage users to change their browser's security settings.
donmccurdy
changed the title
Mugen87
approved these changes
May 21, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* Recommend a local server, don't present it as second option Current wording offers two options and suggests we'll explain both, but then only explains the second. As discussed in mrdoob#15334 we should not encourage users to change their browser's security settings. * Clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current wording offers two options (change browser settings, or use local server) and suggests we'll explain both, but then only explains the second. As discussed in #15334 we should not encourage users to change their browser's security settings. This PR simplifies the wording to present a local server as the default option.
Preview: