Core: allow tree-shaking again for materials #24094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcofugaro
commented
May 20, 2022
Comment on lines
+327
to
+346
| const materialLib = { | ||
| ShadowMaterial, | ||
| SpriteMaterial, | ||
| RawShaderMaterial, | ||
| ShaderMaterial, | ||
| PointsMaterial, | ||
| MeshPhysicalMaterial, | ||
| MeshStandardMaterial, | ||
| MeshPhongMaterial, | ||
| MeshToonMaterial, | ||
| MeshNormalMaterial, | ||
| MeshLambertMaterial, | ||
| MeshDepthMaterial, | ||
| MeshDistanceMaterial, | ||
| MeshBasicMaterial, | ||
| MeshMatcapMaterial, | ||
| LineDashedMaterial, | ||
| LineBasicMaterial, | ||
| Material | ||
| }; |
There was a problem hiding this comment.
This object can safely be in the function thanks to garbage collection.
LeviPesin
reviewed
May 20, 2022
LeviPesin
reviewed
May 20, 2022
LeviPesin
reviewed
May 20, 2022
|
@marcofugaro I tried something similar here #22552 I don't know what @mrdoob would think about it now. |
LeviPesin
reviewed
Jun 8, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* Core: Replace Materia.fromType with MaterialLoader.createMaterialFromType * Remove unused import * Add missing materialLib * Add missing import * Fix import * Add missing SpriteNodeMaterial
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* Core: Replace Materia.fromType with MaterialLoader.createMaterialFromType * Remove unused import * Add missing materialLib * Add missing import * Fix import * Add missing SpriteNodeMaterial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23314 (comment) (why didn't you guys ping me 😅)
Description
Since #23314 materials have not been tree-shakeable (meaning if you don't use
MeshPhysicalMaterialin your scene, it still stays in the final bundle).This is the correct way to have a
fromType()function is to put it in the class where it's needed.MaterialLoaderis the place, since it already handles the creation of the materials.This PR deprecates Material.fromType and replaces it with MaterialLoader.createMaterialFromType.
/cc @sunag