Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFExporter: Fix handling of shared buffer attributes with morph data. #24090

Merged
merged 3 commits into from
May 24, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 19, 2022

Fixed #24074.

Description

Ensures GLTFExporter can correctly process geometries which share buffer attributes (like position) but with different morph target setups.

@Mugen87 Mugen87 added this to the r141 milestone May 19, 2022
@Mugen87 Mugen87 changed the title GLTFExporter: Fix handling of shared buffer attribtues with morph data. GLTFExporter: Fix handling of shared buffer attributes with morph data. May 19, 2022
@mrdoob mrdoob requested a review from donmccurdy May 20, 2022 06:53
examples/jsm/exporters/GLTFExporter.js Outdated Show resolved Hide resolved
examples/jsm/exporters/GLTFExporter.js Outdated Show resolved Hide resolved
examples/jsm/exporters/GLTFExporter.js Outdated Show resolved Hide resolved
@mrdoob mrdoob merged commit 3ca98fb into mrdoob:dev May 24, 2022
@mrdoob
Copy link
Owner

mrdoob commented May 24, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
…a. (mrdoob#24090)

* GLTFExporter: Fix handling of shared buffer attribtues with morph data.

* GLTFExporter: Simplify code.

* GLTFExporter: Clean up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GLTFExporter uses wrong cache value baseAttribute instead of relativeAttribute
3 participants