Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual: translate material table into chinese #24063

Merged
merged 2 commits into from
May 16, 2022

Conversation

MongooseSong
Copy link
Contributor

Translate "material table" into chinese.

That's a very little change, but I also update the table css style because the vertical title text make the table crammed. I am not sure why using "writing-mode: vertical-lr" so I just remove it.

@Mugen87
Copy link
Collaborator

Mugen87 commented May 15, 2022

I've tested your new CSS. The table looks better on my desktop but on mobile devices the headings have ugly line breaks. The existing styles work better in this regard.

TBH, I suggest you do not change styles in translation related PRs. Do this separately otherwise it might delay a merge considerably.

@MongooseSong MongooseSong force-pushed the manual/material_table_zh branch from 7de7dfd to f80ab22 Compare May 15, 2022 13:48
@MongooseSong
Copy link
Contributor Author

I've tested your new CSS. The table looks better on my desktop but on mobile devices the headings have ugly line breaks. The existing styles work better in this regard.

TBH, I suggest you do not change styles in translation related PRs. Do this separately otherwise it might delay a merge considerably.

Thanks for review, I had already removed the relative code. maybe next time I will try to fix it by media query or another way, thanks for your advice 😃

@Mugen87 Mugen87 added this to the r141 milestone May 16, 2022
@Mugen87 Mugen87 merged commit 21686c6 into mrdoob:dev May 16, 2022
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* manual: translate material table into chinese

* fix: remove meterial-table css modify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants