Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color: Do not use prototype for r/g/b properties. #24061

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 14, 2022

Related issue: #24047 (comment)

Description

Just defining r, g and b in the constructor with default values makes the code more readable and more consistent compared the other math classes.

@Mugen87 Mugen87 added this to the r141 milestone May 17, 2022
@mrdoob mrdoob merged commit 366c97f into mrdoob:dev May 17, 2022
@mrdoob
Copy link
Owner

mrdoob commented May 17, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants