-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebXRManager: Fix caching of baseReferenceFrame and teleport example. #24058
Conversation
53d1ec2
to
1880b9e
Compare
94600fe
to
acb81b7
Compare
@arodic thanks for the review :) made that change on removing event handlers as you suggested, I left a comment on why I need to cache the session. |
Excellent! I can confirm that this fix works as intended (tested in Oculus Quest 2). I can also confirm that without this fix, the example is broken if multiple sessions are attempted. |
@richardanaya Can you please update the PR with a |
@LeviPesin Where would that listener go? |
I think https://github.com/mrdoob/three.js/pull/24058/files#diff-28e2f2792c9f311cb52ce985452165df772dcfde81e80f00cd699426ede935c6R107-R116 should be reverted and to the |
@LeviPesin fixed and re-tested according to your suggestion, it's much cleaner :) thank you |
Thanks! |
Fixed #24033
Description
The teleporter example was broken in a few ways.
Video of it working:
a93b746eb1f14bf512196d6628573812.mp4