WebXRController: Fix wrong ray space for Vive OpenXR Runtime. #24056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
May 13, 2022
Mugen87
changed the title
mrdoob
reviewed
Jun 14, 2022
mrdoob
reviewed
Jun 15, 2022
|
Thanks! |
|
Awesome, thank y'all |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was no rays in react/xr on Vive OpenXR Runtime (Vive Cosmos uses it). I started debugging and found out that
inputPose = frame.getPose( inputSource.targetRaySpace, referenceSpace );returnnullon this runtime, howevergripPosewas fine. When I usedgripPosein place ofinputPoseray started doing fine and their directions correlates with the ones I see in native Viveport interface. Looks like grip space and target ray space are the same in Vive OpenXR Runtime. Pretty sure it's a bug, but this provides a workaround with no additional cost