THREE.Legacy.js: Move deprecated propeties and methods to classes. #24040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
May 10, 2022
mrdoob
reviewed
May 11, 2022
|
Thanks! |
This was referenced May 11, 2022
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
…rdoob#24040) * THREE.Legacy.js: Move deprecated propeties and methods to classes. * WebGLRenderer: Make gammaFactor configurable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #24006
Description
This PR moves legacy properties and methods to classes instead of keeping them in
THREE.Legacy.js.Deprecated code is marked with the
@deprecatedannotation. By searching for@deprecatedin thesrcdirectory, you quickly see all legacy code sections and the respective release when they were removed.