Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual: Fix links of primitives page. #24026

Merged
merged 1 commit into from
May 8, 2022
Merged

Manual: Fix links of primitives page. #24026

merged 1 commit into from
May 8, 2022

Conversation

taenykim
Copy link
Contributor

@taenykim taenykim commented May 8, 2022

Fixed #24025

Description

An error occurred when clicking on Box Geometry because it creates another panel within the iframe.

The location is different between docs and manual, so I think there will be a lot of side effects. So I modified it to replace the parent page if the HTML is loaded within the iframe.

I would appreciate it if you could let me know if there is another good way.


Thanks to the kind document, I am having fun studying threejs

@Mugen87
Copy link
Collaborator

Mugen87 commented May 8, 2022

How about we use the same approach like when linking from the docs to the examples? Meaning the site is opened in a new tab.

In this way, the issue can be fixed in the manual without touching the docs. It should be sufficient to add the following line:

a.setAttribute('target', '_blank');

at this place:

const a = document.createElement('a');

@taenykim
Copy link
Contributor Author

taenykim commented May 8, 2022

The solution you suggested is better. 😄 I modified it

@Mugen87 Mugen87 changed the title Docs: Modify docs index.html Manual: Fix links of primitives page. May 8, 2022
@Mugen87 Mugen87 added this to the r141 milestone May 8, 2022
@Mugen87 Mugen87 merged commit 13de4a6 into mrdoob:dev May 8, 2022
@mrdoob
Copy link
Owner

mrdoob commented May 9, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation contents overlaps when navigating from manual page to docs page
3 participants