Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtrudeGeometry: Fix toJSON() when using extrudePath. #24013

Merged
merged 3 commits into from
May 7, 2022
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 5, 2022

Fixed #24010.

Description

This PR ensures that the data object does have a reference to original options parameter object of ExtrudeGeometry.

@Mugen87 Mugen87 added this to the r141 milestone May 5, 2022
@Mugen87 Mugen87 merged commit 154e543 into dev May 7, 2022
@Mugen87 Mugen87 deleted the Mugen87-patch-1 branch May 7, 2022 08:12
@mrdoob
Copy link
Owner

mrdoob commented May 9, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* Update ExtrudeGeometry.js

* Update ExtrudeGeometry.js

* Update ExtrudeGeometry.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CatmullRomCurve3.toJSON() works only once
2 participants