Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLTFExporter: Remove embedImages option. #24003

Merged
merged 1 commit into from
May 5, 2022
Merged

GLTFExporter: Remove embedImages option. #24003

merged 1 commit into from
May 5, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 4, 2022 •
edited
Loading

Fixed #23962.

Description

Removes the problematic embedImages option from GLTFExporter.

That means images are always embedded in the glTF asset now.

donmccurdy
donmccurdy approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Mugen87 Mugen87 added this to the r141 milestone May 5, 2022
@Mugen87 Mugen87 merged commit 8b41700 into mrdoob:dev May 5, 2022
@Mugen87 Mugen87 mentioned this pull request May 5, 2022
Closed
@mrdoob
Copy link
Owner

mrdoob commented May 6, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
@Mugen87 @abernier
GLTFExporter: Remove embedImages option. (mrdoob#24003)
64d1afb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r141
Development

Successfully merging this pull request may close these issues.

GLTFExporter: jpeg textures on export binary and embedImages=false cause validation error
3 participants
@Mugen87 @mrdoob @donmccurdy