Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebXRManager: add undefined check in onSessionEnd() #23984

Merged
merged 2 commits into from
May 6, 2022
Merged

WebXRManager: add undefined check in onSessionEnd() #23984

merged 2 commits into from
May 6, 2022

Conversation

kalegd
Copy link
Contributor

@kalegd kalegd commented May 1, 2022

This commit adds a undefined check prior to disconnecting the controller in onSessionEnd() as described in #23983

Fixed #23983

Description

Lack of undefined check for controllers in onSessionEnd causes errors if getController is never called. Undefined check prevents errors

kalegd added 2 commits May 1, 2022 06:24
This commit adds a null check prior to disconnecting the controller in `onSessionEnd()` as described in #23983
@Mugen87 Mugen87 added this to the r141 milestone May 2, 2022
@Mugen87 Mugen87 merged commit 65ffdea into mrdoob:dev May 6, 2022
@Mugen87 Mugen87 mentioned this pull request May 6, 2022
@mrdoob mrdoob changed the title WebXRManager: add null check in onSessionEnd() WebXRManager: add undefined check in onSessionEnd() May 6, 2022
KallynGowdy pushed a commit to casual-simulation/three.js that referenced this pull request May 24, 2022
* WebXRManager: add null check in onSessionEnd()

This commit adds a null check prior to disconnecting the controller in `onSessionEnd()` as described in mrdoob#23983

* Fix spacing for Lint
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* WebXRManager: add null check in onSessionEnd()

This commit adds a null check prior to disconnecting the controller in `onSessionEnd()` as described in mrdoob#23983

* Fix spacing for Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebXRManager throws error in onSessionEnd if getController is never called
3 participants