Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferGeometryUtils: Remove use of old Material.morphTargets property #23955

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

willstott101
Copy link
Contributor

Related issue: #23951

Description

In #22169 the Material.morphTargets boolean property was removed, but BufferGeometryUtils.computeMorphedAttributes was left using it.

This means computeMorphedAttributes is not currently applying morph targets to morphed meshes.

@willstott101
Copy link
Contributor Author

willstott101 commented Apr 27, 2022

Would it be helpful to open a dedicated issue for this? Does that help with the changelog or anything like that?

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 27, 2022

Not necessary. A PR for tracking the changes is sufficient.

@Mugen87 Mugen87 added this to the r140 milestone Apr 27, 2022
@takahirox
Copy link
Collaborator

The change looks good to me. And the second argument material can be removed from _calculateMorphedAttributeData() because it will no longer be used?

function _calculateMorphedAttributeData( object, material, attribute, morphAttribute, morphTargetsRelative, a, b, c, modifiedAttributeArray ) {

@willstott101 willstott101 force-pushed the fix/computeMorphedAttributes branch from 804c3c1 to d4bac13 Compare April 27, 2022 17:27
@willstott101
Copy link
Contributor Author

Yep right you were - I realised I had edited the JS file not the JSM file, so force pushed. I hope that's not too irritating

Copy link
Collaborator

@takahirox takahirox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested yet because no example uses the method, but looks good to me. Thanks for the update.

@Mugen87 Mugen87 merged commit 66d3ccb into mrdoob:dev Apr 28, 2022
@mrdoob
Copy link
Owner

mrdoob commented Apr 28, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants